Kound
Kound
@davidism once you check the code, have a lock especially on the async stuff. I have no experience with async coding what so ever, so my changes are more like...
@davidism can I support/help you in any way with the review?
Sorry I am not yet that experienced with rebasing. What would be the workflow in an existing PR like this? I would assume: 1. After your added the Type Annotations...
@davidism just tell me once you finished the merge of the type annotations...
> I think @davidism meant, that you should squash (https://levelup.gitconnected.com/how-to-squash-git-commits-9a095c1bc1fc) your 71 commits into one (and maybe force push the result to this branch). > > After @davidism applied the...
@davidism Did the rebase and combination as requested. One thing: When are you planning to release 3.0? Are you following SemVer? Because if you do it would be good not...
First of all. Sorry I missed that release. Big thing, updating all libraries at once. Congratulations 🎉 > We don't follow semver. Good to know. > > I don't understand...
@davidism I changed things as requested. If there are still any issues, let me know.
@davidism and @ThiefMaster will this ever be merged?
@davidism just another ping. Anything I can do to support you on this MR?