fable icon indicating copy to clipboard operation
fable copied to clipboard

Accept error tuples in emit

Open benwilson512 opened this issue 5 years ago • 4 comments

benwilson512 avatar Jan 27 '20 23:01 benwilson512

Thoughts @LostKobrakai ?

benwilson512 avatar Jan 27 '20 23:01 benwilson512

I generally like it. The typespec would need updating though.

Also I'd skip the arity-1 callback option. If we introduce the new version of ecto Repo.transaction does pass the repo to both multi and functions passed in. So I'd go for fn aggregate, repo -> or fn aggregate, repo, changes ->. I feel this is nearer to ecto, where at least for multi usage repo is also passed all the time.

LostKobrakai avatar Jan 28 '20 08:01 LostKobrakai

That's fair, can you elaborate on use of changes? I'm not sure I see when it would be used.

benwilson512 avatar Jan 28 '20 14:01 benwilson512

It‘s the changes provided by Ecto.Multi.run and ….merge.

LostKobrakai avatar Jan 28 '20 15:01 LostKobrakai