cardboard icon indicating copy to clipboard operation
cardboard copied to clipboard

Do not handle player death in MixinPlayer. Temporary fix for #420

Open vadim-a-yegorov opened this issue 2 years ago • 4 comments

vadim-a-yegorov avatar Jul 12 '23 06:07 vadim-a-yegorov

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jul 12 '23 06:07 CLAassistant

It should not be fixed by simply remove it,make a try to better handle it.

wdog5 avatar Jul 24 '23 00:07 wdog5

It should not be fixed by simply remove it,make a try to better handle it.

I’m not a developer. Who wrote this fatal code and allowed it to be in production is not a good developer either. It should be removed from the master branch.

vadim-a-yegorov avatar Jul 24 '23 07:07 vadim-a-yegorov

@wdog5 Please take a look at https://github.com/CardboardPowered/cardboard/issues/420 and try to handle it.

vadim-a-yegorov avatar Jul 24 '23 07:07 vadim-a-yegorov