forge icon indicating copy to clipboard operation
forge copied to clipboard

Rite of Ruin messy script

Open tool4ever opened this issue 1 year ago • 1 comments

          i mean yeah, the Effect might work

my concern was more about it if we could simplify the code somehow

Originally posted by @Hanmac in https://github.com/Card-Forge/forge/pull/5046#discussion_r1566840765

tool4ever avatar Apr 18 '24 17:04 tool4ever

FWIW, here's my sketch of an attempt at simplifying the script for Rite of Ruin, trying my best to use existing parameters that, I assumed, could at least be expanded/iterated easily enough. The stuff I haven't come across in existing scripts is as clearly marked out as I could make it. rite_of_ruin_3.txt While I felt adding the dichotomy Permanent/NonPermanent to the arguments of Type$ was reasonable and I hoped expanding ChooseType/ChosenType parameter/argument sequence to a third iteration wouldn't be too much trouble, @tehdiplomat noted that there was work already done for a less explicit way of ordering types.

dracontes avatar Apr 20 '24 17:04 dracontes