refactor LandAbility to be created by CardFactory
Closes #165 Part of my Old MayPlay rework
this changes the LandAbility to be created in CardFactory, so it can be copied if needed
this makes it easier when we are reworking MayPlay later
@tehdiplomat can you look why the test is failing?
@Hanmac
Evaluating... (orig score = 346) 0: [549] Simic Growth Chamber (2) -> Play land (chosen: Forest) 0: [346] Simic Growth Chamber (2) -> Play land (chosen: Simic Growth Chamber) 0: [572] Forest (3) -> Play land BEST: Forest (3) -> Play land SCORE: 572 TIME: 2628 Current phase (MAIN1) plan with score 572:
It looks like it thinks playing the Forest is better than playing the Chamber now. Maybe something you changed also needs to update something in the calculate score logic?
this is only safe because nothing can turn a non-permanent into a land right now, right? 🤔 I'm not sure if that assumption will continue to hold though, especially with Alchemy - feels like "perpetually becomes a land" can happen anytime at this point...
this is only safe because nothing can turn a non-permanent into a land right now, right? 🤔 I'm not sure if that assumption will continue to hold though, especially with Alchemy - feels like "perpetually becomes a land" can happen anytime at this point...
I think it should be safe for now?
It would help me with clean up when I try to update the Aura Spell Enchant Keyword thing
"perpetually becomes a land"
The Problem there is also that if something becomes a Land, you should not be able to cast it anymore? So as long as that doesn't happen, it should be okay?
@tool4ever can we look into it? This might help us with MayPlay changes in the Future
AI no longer uses Crucible of Worlds...
Time to fix AI again :(
@tool4ever fixed AI not playing Lands via MayPlay