forge icon indicating copy to clipboard operation
forge copied to clipboard

refactor LandAbility to be created by CardFactory

Open Hanmac opened this issue 1 year ago • 5 comments

Closes #165 Part of my Old MayPlay rework

this changes the LandAbility to be created in CardFactory, so it can be copied if needed

this makes it easier when we are reworking MayPlay later

Hanmac avatar Apr 15 '24 20:04 Hanmac

@tehdiplomat can you look why the test is failing?

Hanmac avatar Apr 15 '24 20:04 Hanmac

@Hanmac

Evaluating... (orig score = 346) 0: [549] Simic Growth Chamber (2) -> Play land (chosen: Forest) 0: [346] Simic Growth Chamber (2) -> Play land (chosen: Simic Growth Chamber) 0: [572] Forest (3) -> Play land BEST: Forest (3) -> Play land SCORE: 572 TIME: 2628 Current phase (MAIN1) plan with score 572:

It looks like it thinks playing the Forest is better than playing the Chamber now. Maybe something you changed also needs to update something in the calculate score logic?

tehdiplomat avatar Apr 16 '24 02:04 tehdiplomat

this is only safe because nothing can turn a non-permanent into a land right now, right? 🤔 I'm not sure if that assumption will continue to hold though, especially with Alchemy - feels like "perpetually becomes a land" can happen anytime at this point...

tool4ever avatar May 28 '24 13:05 tool4ever

this is only safe because nothing can turn a non-permanent into a land right now, right? 🤔 I'm not sure if that assumption will continue to hold though, especially with Alchemy - feels like "perpetually becomes a land" can happen anytime at this point...

I think it should be safe for now?

It would help me with clean up when I try to update the Aura Spell Enchant Keyword thing

Hanmac avatar May 28 '24 14:05 Hanmac

"perpetually becomes a land"

The Problem there is also that if something becomes a Land, you should not be able to cast it anymore? So as long as that doesn't happen, it should be okay?

Hanmac avatar Jun 19 '24 09:06 Hanmac

@tool4ever can we look into it? This might help us with MayPlay changes in the Future

Hanmac avatar Aug 21 '24 12:08 Hanmac

AI no longer uses Crucible of Worlds...

tool4ever avatar Aug 21 '24 13:08 tool4ever

Time to fix AI again :(

Hanmac avatar Aug 21 '24 13:08 Hanmac

@tool4ever fixed AI not playing Lands via MayPlay

Hanmac avatar Aug 21 '24 19:08 Hanmac