forge icon indicating copy to clipboard operation
forge copied to clipboard

Are triggeringObjects sometimes set too late?

Open tool4ever opened this issue 1 year ago • 3 comments

I was investigating #2248 for Welcoming Vampire follow-up (since ChangesZoneAll supports some LKI now):

And while it does trigger now, it fails to set the triggeringObjects correctly because its Valid filtering only happens later (after the token has the Equipment buff) - Not a big deal in this case but probably matters somewhere.

Maybe for more accurary the triggeringObjects should also be set when the WaitingTrigger is created? (just like with Controller done in #4484)

Also what I did for Mentor of the Meek in the related PR still has room for improvement with simultaneous zone changes: currently I still get one trigger if two Kongming ETB together

tool4ever avatar Mar 20 '24 11:03 tool4ever

Also what I did for Mentor of the Meek in the related PR still has room for improvement with simultaneous zone changes: currently I still get one trigger if two Kongming ETB together

if two Kongming would enter at the same time, then Mentor of the Meek should not trigger because both should enter as 3/3 before legend rule removes one of them and the remaining becomes 2/2 again ?

Hanmac avatar Mar 20 '24 11:03 Hanmac

Yes, the LKI for cardsAddedThisTurn is created at a bad time (before the second one is processed) :/

tool4ever avatar Mar 20 '24 11:03 tool4ever

i think what GameAction could do is to:

  • add the stuff into a GameCommand/Callback ala: "cardsAddedThisTurn.add(newCreature)"
  • them Static Abilities can apply
  • then call the GameCommands, Do LKI, Apply Trigger
  • Do Legend Rule
  • And then Put the Trigger on the Stack

Hanmac avatar Mar 20 '24 11:03 Hanmac