forge icon indicating copy to clipboard operation
forge copied to clipboard

etbCounter needs to be Removed in the Future

Open Hanmac opened this issue 2 years ago • 2 comments

etbCounter currently makes problems with CardTextChanges because the value for X is not affected by it but it should. Example: Ulasht, the Hate Seed

In the work of changing ETB Keywords into a Form that used "ReplacementResult.Updated" instead of using ETBInternal, it will be much cleaner to use normal replacement Effects instead of using a Keyword

This is part of the Cleanup of CardFactoryUtil to remove everything what isn't a "real Keyword"

Hanmac avatar May 02 '22 14:05 Hanmac

Just some cards that I think might need special attention when doing this refactor:

  • Agent's Toolkit
  • the IKO "this card enters with your choice of counter A or counter B" stuff

Northmoc avatar May 08 '22 15:05 Northmoc

yeah, extracting from a keyword into an replacement effect isn't that big of a problem.

it's just to not use the keyword anymore

Hanmac avatar May 08 '22 15:05 Hanmac

This issue has not been updated in a while and has now been marked as stale. Stale messages will be auto closed.

github-actions[bot] avatar Jul 03 '23 09:07 github-actions[bot]