Moved replacement causing wrong ChangesZoneAll trigger

[tool4ever]

When you destroy the Griffin Welcoming Vampire will trigger. This is because the RiP RE only changes the zone of the copied card, so the ChangeZoneTable will be {Battlefield={Battlefield=[Abbey Griffin]}}

@Hanmac my current idea is to just return game.getCardState(c) here: https://github.com/Card-Forge/forge/blob/e7f6b3371a2642ce625abce01c8b2bab21c2c368/forge-game/src/main/java/forge/game/GameAction.java#L382

or at the very least update the zone of c with the new one?

Edit: probably not good enough, that would still cause triggerChangesZoneAll twice, once from RE ChangeZoneEffect and second from DestroyEffect

[Hanmac]

imo what should be done is that RIP does Replace and Update the Destination / zoneTo (while still respecting "ExiledWith")

[tool4ever]

Yea that's probably needed, it will also fix the splitting of simultaneous events into multiple, e.g. in this scenario Ranar should only trigger once but currently it's twice:

[tool4ever]

Fixing this will also avoid UntilHostLeavesPlay being dropped

[github-actions[bot]]

This issue has not been updated in a while and has now been marked as stale. Stale messages will be auto closed.

[github-actions[bot]]

This issue has not been updated in a while and has now been marked as stale. Stale messages will be auto closed.

[Hanmac]

@tool4ever what we could try is pasting the change Zone Table as Replacement parameter to fill

with that, the outer Destroy Effect creates the Table and the inner Effect notices that its inside a Move Replacement Effect and just updates the data in the Table (with keeping old lki in tact?)