forge icon indicating copy to clipboard operation
forge copied to clipboard

make LandAbility work for ValidSA

Open Northmoc opened this issue 3 years ago • 2 comments

i really need to make LandAbility work for ValidSA

Originally posted by @Hanmac in https://github.com/Card-Forge/forge/pull/162#discussion_r860794151

This would be great for streamlining Ziatora's Envoy

==

  • LandAbility should probably be created by CardFactory when reading the CardFace in a similar way how Spell Permanent is created.

  • this might cleanup other mayPlay stuff

  • If Enchant Keyword is updated, Spell Permanent would needs to be updated for Auras too

Northmoc avatar Apr 28 '22 12:04 Northmoc

This issue has not been updated in a while and has now been marked as stale. Stale messages will be auto closed.

github-actions[bot] avatar Jul 05 '23 09:07 github-actions[bot]

@tool4ever maybe i look into this first

this should be as simple as this in CardFactory

SpellAbility sa = new LandAbility(c);
sa.setCardState(c.getCurrentState());
c.addSpellAbility(sa);

Hanmac avatar Apr 15 '24 13:04 Hanmac