captain-fact icon indicating copy to clipboard operation
captain-fact copied to clipboard

Behaviour depending on environments should be configured not hardcoded

Open Betree opened this issue 7 years ago • 0 comments

In several places, the code behaviour rely on which env it is running on

Places should be listed down here :

  • apps/captain_fact/lib/captain_fact/accounts/accounts.ex #fetch_picture (now line 182)

The right solution is to implement test purpose module and to configure it. An example for such thing is the Arc storage : S3 in production, local in dev and test

Betree avatar Aug 22 '18 18:08 Betree