pac3 icon indicating copy to clipboard operation
pac3 copied to clipboard

Halo part having forced affect children behaviour

Open TheReeb opened this issue 3 years ago • 7 comments

When placing a halo part parented under a model, any other models also parented under it will have the halo effect display, regardless if you tick "affect children" in its settings or not.

Tested on developer and workshop builds.

https://user-images.githubusercontent.com/65454681/205440432-fc755fbe-f0fb-4702-9a0a-7f9c5e66ad8e.mp4

TheReeb avatar Dec 03 '22 12:12 TheReeb

Affect children affects the children of the halo not the part that it targets

Yagira avatar Dec 03 '22 12:12 Yagira

Affect children affects the children of the halo not the part that it targets

It used to work with this method in the past, so that makes no sense. If I parent it underneath Model A, I want that Model A to have the halo. If I tick affect children after that, Model B should be affected too then

TheReeb avatar Dec 03 '22 12:12 TheReeb

I'm pretty sure affect children never worked like that, it always affects the children of the part that uses it. It's the same for every part with the affect children property. What you are referring to is probably the "affect siblings" behavior which got added to halos a while ago after someone requested it. Problem is it works in a weird way and can't even be disabled. I changed it to affect target children which should work closer to what people expect, it should also respect target entity from now on.

Give it a try and see if it works as you want it to. https://github.com/CapsAdmin/pac3/archive/refs/heads/develop.zip

Yagira avatar Dec 03 '22 15:12 Yagira

I'm pretty sure affect children never worked like that, it always affects the children of the part that uses it. It's the same for every part with the affect children property. What you are referring to is probably the "affect siblings" behavior which got added to halos a while ago after someone requested it. Problem is it works in a weird way and can't even be disabled. I changed it to affect target children which should work closer to what people expect, it should also respect target entity from now on.

Give it a try and see if it works as you want it to. https://github.com/CapsAdmin/pac3/archive/refs/heads/develop.zip

When was such feature added? It sounds counterintuitive to add a feature you can't even turn off when you don't want it. Perhaps there's something conflicting with how halos are drawn somewhere else. Either way, the way I remember how it works and still do, having a version of PAC before the big refactoring, was that Model A with a halo parented under it, will affect any model parented to Model A, so Model B, C, D, etc. would all get the halo effect if you tick "affect children". Maybe a rename could clear up confusions about it.

I will give this a try again.

TheReeb avatar Dec 03 '22 15:12 TheReeb

Well that didn't take long at all.

So good news: It works as expected and intended.

The strange news is well.. I encountered some unusual things when testing. The video below shows it better (couldn't embed sorry)

https://cdn.discordapp.com/attachments/907945789970608148/1048624640832057384/Garrys_Mod_2022.12.03_-_16.35.04.05.mp4

I also tried it with a clip, cause I recall you can clip models with halo effects on them. It isn't however working quite as intended

TheReeb avatar Dec 03 '22 15:12 TheReeb

Ye that seems like a separate issue

Yagira avatar Dec 03 '22 15:12 Yagira

Well besides that strange interaction, it works now

TheReeb avatar Dec 03 '22 19:12 TheReeb