Cap icon indicating copy to clipboard operation
Cap copied to clipboard

Refactor: Convert RGBA to RGB with bounds checking in MP4 export

Open seer-by-sentry[bot] opened this issue 1 month ago • 1 comments

Fixes CAP-DESKTOP-J2. The issue was that: Screenshot generation incorrectly slices padded GPU texture data, causing memory corruption detected by macOS VFX framework during Metal texture processing.

  • Converts RGBA frame data to RGB during MP4 export.
  • Implements bounds checking to prevent memory access violations when processing frame data, ensuring robustness.
  • Uses min to safely handle cases where row length is shorter than expected.
  • Ensures chunk has at least 3 bytes (RGB) before accessing.

This fix was generated by Seer in Sentry, triggered by Richie. 👁️ Run ID: 2575842

Not quite right? Click here to continue debugging with Seer.

seer-by-sentry[bot] avatar Nov 11 '25 12:11 seer-by-sentry[bot]

[!IMPORTANT]

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Comment @coderabbitai help to get the list of available commands and usage tips.

coderabbitai[bot] avatar Nov 11 '25 12:11 coderabbitai[bot]