Invit email can create user

[riderx]

Describe the bug/issue when invite a user to the org, the user needs to exist first, it's terrible UX. Make the invite check if the user, exists and if not exist demand same info as the register page and register the user. Then add him to the org. The new user still needs to verify their email. use admin sdk in backend supabase.auth.admin create a function for that in supabase

[riderx]

@devin let's do it

[devin-ai-integration[bot]]

Review of PR #1073: Implement User Creation During Organization Invitation

Implementation Review

The implementation in PR #1073 successfully addresses the requirements specified in issue #1068 to improve the user invitation process. The changes allow organization administrators to create new user accounts during the invitation process when the invited email doesn't exist in the system.

Key implementation points:

• Modified the invitation workflow to check if a user exists
• Added a confirmation dialog asking if the admin wants to create a new user
• Implemented forms to collect first and last name for new users
• Created backend functionality to handle user creation via Supabase Admin SDK
• Added SQL wrapper functions to support the new workflow
• Maintained email verification requirement for security

Code Quality Assessment

The code quality is high and follows the project's established patterns and conventions:

• Frontend (Members.vue):

  • Clean implementation using Vue 3 setup script
  • Proper error handling with user feedback
  • Follows existing dialog patterns for consistency
  • Maintains separation of concerns between UI and API calls

• Backend (organization/members/post.ts):

  • Well-structured with clear function separation
  • Comprehensive error handling
  • Proper validation using zod schema
  • Follows security best practices

• Database (SQL migration):

  • Created wrapper functions to avoid modifying existing functionality
  • Used SECURITY DEFINER for proper access control
  • Maintained data integrity checks

• Internationalization:

  • All user-facing text is properly internationalized
  • Messages are clear and consistent with existing terminology

UX Workflow Evaluation

The new workflow is intuitive and user-friendly:

1. Admin initiates invitation by entering email address
2. System prompts whether to create a user if the email doesn't exist
3. If confirmed, system collects first and last name through simple forms
4. Backend creates the user account and adds them to the organization
5. User receives email verification as required
6. Admin receives clear feedback about the outcome

This workflow significantly improves the user experience by eliminating the need for admins to ask users to create accounts before inviting them to an organization.

Security Considerations

The implementation maintains strong security practices:

• User creation is handled securely in the backend using Supabase Admin SDK
• Email verification is still required for new users
• Permission checks ensure only authorized admins can create users
• SQL functions use SECURITY DEFINER to prevent unauthorized access
• Proper error handling prevents information leakage

Recommendations

The implementation is well-designed and addresses the requirements effectively. I recommend approving this PR as it provides a valuable UX improvement that will make organization management more efficient.

Additional considerations for future enhancements:

• Consider adding the ability to set additional user metadata during creation
• Add analytics to track how often this feature is used
• Consider extending the feature to allow bulk user creation for larger organizations

Overall, this is a well-implemented feature that maintains security while improving usability.

[riderx]

close in favor of https://github.com/Cap-go/capgo/issues/680