capacitor-updater icon indicating copy to clipboard operation
capacitor-updater copied to clipboard

R&D download before start first open

Open riderx opened this issue 3 years ago β€’ 1 comments

TO have the same behavior as Burger king app IMG_4103 We could use a wording like : 'We are optimizing your app experience'

riderx avatar May 03 '22 21:05 riderx

This is R&D for auto-update, note for manual is it's already possible.

meilechwieder avatar May 03 '22 21:05 meilechwieder

/bounty $100

riderx avatar Feb 14 '23 23:02 riderx

πŸ’Ž $100 bounty created by riderx πŸ™‹ If you start working on this, comment /attempt #72 to notify everyone πŸ‘‰ To claim this bounty, submit a pull request that includes the text /claim #72 somewhere in its body πŸ“ Before proceeding, please make sure you can receive payouts in your country πŸ’΅ Payment arrives in your account 2-5 days after the bounty is rewarded πŸ’― You keep 100% of the bounty award ℹ️ If something is not clear ask before working on it, otherwise your chance to rework it is high πŸ‘¨β€πŸ‘©β€πŸ‘§β€πŸ‘¦ Join the Discord to get help πŸ™ Thank you for contributing to Cap-go/capacitor-updater!

Attempt Started (GMT+0) Solution
🟒 @ayewo Aug 9, 2023, 7:40:00 PM #242

algora-pbc[bot] avatar Feb 14 '23 23:02 algora-pbc[bot]

Hello, I'd like to work on this issue :)

aazam-gh avatar Apr 06 '23 20:04 aazam-gh

Hi @Alcadeus0 that awesome ! please feel free to ask here any missing info

riderx avatar Apr 07 '23 23:04 riderx

@riderx How do I reproduce this issue?

aazam-gh avatar Apr 08 '23 00:04 aazam-gh

@Alcadeus0 you can use the demo app: https://github.com/Cap-go/demo-app

Acceptance criterial:

  • updated should be download and apply at first launch
  • a loader is visible while the download happen
  • works both in ios and android
  • no code duplication

riderx avatar Apr 08 '23 07:04 riderx

@riderx running npx cap verify gives me image why isn't the pod being found?

aazam-gh avatar Apr 08 '23 10:04 aazam-gh

this command run from the CI and in local, did you run the command in the root folder?

riderx avatar Apr 09 '23 19:04 riderx

yes I'm running in the root folder, maybe that's why

aazam-gh avatar Apr 09 '23 19:04 aazam-gh

mmm ok sorry, you have to have the package manager cocoa pods and use a mac. This task is pretty hard, good knowledge in ios/android is recommended. plus you have to understand capacitor env

riderx avatar Apr 10 '23 04:04 riderx

@riderx i see that's understandable. I use Ubuntu so it won't be possible even if i decide to use a vm with mac OS. You can un-assign me from the issue

aazam-gh avatar Apr 10 '23 05:04 aazam-gh

I can grant you of half the price if you find a solution in android

riderx avatar Apr 10 '23 15:04 riderx

Sure, I'll give it a shot

aazam-gh avatar Apr 10 '23 15:04 aazam-gh

Hi @meilechwieder,

Regarding your earlier comment:

This is R&D for auto-update, note for manual is it's already possible.

If you have a moment, mind sharing more details how you currently do it manually?

ayewo avatar Aug 09 '23 14:08 ayewo

Here goes nothing while I /attempt #72 .

Options

ayewo avatar Aug 09 '23 19:08 ayewo

Hey @ayewo I made half of this working, it's done in IOS, I still have some issue in Android. Have you something on your side ? Maybe we can join forces

riderx avatar Aug 17 '23 14:08 riderx

Hi @riderx

Maybe we can join forces

You've already done 50% do I really have a choice πŸ˜€?

Since you've coded the iOS implementation, perhaps you could share it so I can translate it for Android.

ayewo avatar Aug 17 '23 19:08 ayewo

I'm sorry, I really needed it, and a shower showed me the way ^^. I just finished the Android part as well 5 min ago.

So the bounty in this state is not available anymore. I would more now try to battle test it, and be sure this work 100% of the time. Can you help on that ? I can do 100 bounty for this

riderx avatar Aug 17 '23 19:08 riderx

Haha @ shower thoughts 😁

Sure. I updated the capacitor-related dependencies for the demo-app from v4.x.x to v5.x. and will share that later.

Is that what you used for initial testing.

ayewo avatar Aug 17 '23 19:08 ayewo

i use prod app but you can use this one too

riderx avatar Aug 17 '23 20:08 riderx

πŸ’‘ @ayewo submitted a pull request that claims the bounty. You can visit your org dashboard to reward.

algora-pbc[bot] avatar Aug 18 '23 21:08 algora-pbc[bot]

Hey Martin @riderx,

Testing on iOS and Android ended up taking quite a bit of time ... I think some refactoring and/or some unit tests will be usefulβ€”especially for the partial download featureβ€”as I ran into some scenarios where some bundles were failing to delete.

Miscellaneous Issues

  • On Android, I did get the occasional A resource failed to call release so there's a resource leak somewhere.
  • The CLI seems to output an invalid URL at the end of a bundle upload. Towards the end, it will offer the following 404 URL https://web.capgo.app/app/p//logs in its output (or maybe I don't have authorization to see it?):
●  Check logs in https://web.capgo.app/app/p//logs to see if update works.
β”‚
●  Welcome onboard ✈️!
β”‚
●  Your Capgo update system is setup
β”‚
●  Next time use `npx @capgo/cli@latest bundle upload` to only upload your bundle
β”‚
β””  Bye πŸ‘‹

ayewo avatar Aug 18 '23 22:08 ayewo

I think you are right i never tested end to end local env so that could be broken, if you need time to fix it i can do bounty for that

riderx avatar Aug 18 '23 22:08 riderx

The demo app worked on both iOS and Android in my testing. Had to fix a minor logic bug in the demo app (the Splashscreen was shown too quickly, an if block never got called) and fixed a minor bug in the iOS plugin.

For the miscellaneous issues, I can open a separate ticket for them later as they’ll require time for me to investigate and fix them.

Right now, I’m trying to complete the work I started on #119 so please accept the PRs I opened for this issue:

  • https://github.com/Cap-go/capacitor-updater/pull/242
  • https://github.com/Cap-go/demo-app/pull/29
  • https://github.com/Cap-go/demo-app/pull/30

Thanks!

ayewo avatar Aug 19 '23 06:08 ayewo

πŸŽ‰πŸŽˆ @ayewo has been awarded $100! 🎈🎊

algora-pbc[bot] avatar Aug 22 '23 03:08 algora-pbc[bot]

Hi!, i have a question

Where i can see how to make a loading page with auto update: true and direct: true?

FernetB avatar Feb 23 '24 21:02 FernetB

You can find it here: https://capgo.app/docs/plugin/force-update/#direct-update

riderx avatar Feb 24 '24 17:02 riderx