capacitor-native-biometric icon indicating copy to clipboard operation
capacitor-native-biometric copied to clipboard

feat: Implement better security by lubbo

Open riderx opened this issue 10 months ago • 2 comments

Current problem

https://github.com/epicshaggy/capacitor-native-biometric/pull/89

Preferred solution

.

Alternative options

No response

Additional context

No response

Before submitting

  • [x] I have read and followed the feature request guidelines.
  • [x] I have attached links to possibly related issues and discussions.

Fastest way to get this feature added

riderx avatar Feb 09 '25 03:02 riderx

Hi @riderx, how do you want to proceed? Do you need to keep the code as much aligned as possible to the forked repo or we can think about refactoring a bit?

I strongly suggest to proceed step by step in different PRs (my original PR was probably too complex to be accepted)

  1. Refactor the native code in order to simplify classes and cleanup the code before implementing new logic.
  • Android
    • new AuthActivityViewModel to implement MVVM and extract logic form the Activity
    • new CryptoManager to extract crypto implementation from the Plugin
    • new Credentials model
  • iOS
    • new CryptoManager to extract crypto implementation from the Plugin
    • new Credentials model
  1. Implement new biometric features

lubbo avatar Feb 10 '25 07:02 lubbo

Hey @lubbo thanks for the prompt answer. We can refactor, i just already made some refactor, what is important is not making breaking changes in JS interface if additions make it optional.

riderx avatar Feb 17 '25 18:02 riderx