capacitor-native-biometric
capacitor-native-biometric copied to clipboard
feat: Implement better security by lubbo
Current problem
https://github.com/epicshaggy/capacitor-native-biometric/pull/89
Preferred solution
.
Alternative options
No response
Additional context
No response
Before submitting
- [x] I have read and followed the feature request guidelines.
- [x] I have attached links to possibly related issues and discussions.
Fastest way to get this feature added
- [ ] I want to get this feature ASAP and found the issue with Algora we recommend ($100 to $1000)
Hi @riderx, how do you want to proceed? Do you need to keep the code as much aligned as possible to the forked repo or we can think about refactoring a bit?
I strongly suggest to proceed step by step in different PRs (my original PR was probably too complex to be accepted)
- Refactor the native code in order to simplify classes and cleanup the code before implementing new logic.
- Android
- new AuthActivityViewModel to implement MVVM and extract logic form the Activity
- new CryptoManager to extract crypto implementation from the Plugin
- new Credentials model
- iOS
- new CryptoManager to extract crypto implementation from the Plugin
- new Credentials model
- Implement new biometric features
Hey @lubbo thanks for the prompt answer. We can refactor, i just already made some refactor, what is important is not making breaking changes in JS interface if additions make it optional.