broot icon indicating copy to clipboard operation
broot copied to clipboard

viewing image in broot on kitty using filling too much ram

Open mukul1729 opened this issue 1 year ago • 9 comments

When i view images in broot on kitty terminal, it consistently adds the images into the ram, it never frees it even if i close broot. I will attach the video for your reference. It doesnt happen with fzf tho.

https://github.com/user-attachments/assets/f16941d7-11ee-4c8d-9414-cc5ed4aa5f24

mukul1729 avatar Sep 23 '24 14:09 mukul1729

I don't reproduce this.

Can you please launch broot with debug log enabled, view 2 images, then quit, and post the log here ?

Also please post your exact version of Kitty.

Canop avatar Sep 23 '24 14:09 Canop

kitty 0.36.2 broot.log

mukul1729 avatar Sep 23 '24 14:09 mukul1729

once I was casually browsing images in broot and it actually filled whole 8 gigs of ram and swap, and my system crashed

mukul1729 avatar Sep 23 '24 14:09 mukul1729

once I was casually browsing images in broot and it actually filled whole 8 gigs of ram and swap, and my system crashed

I fully understand it's a major bug. I just don't see ATM anything suspect in your log so I don't have explanation for now. I'll have to search for a way to diagnose what happens on your system. Does it happen if you use another compatible terminal, eg wezterm ?

Canop avatar Sep 23 '24 14:09 Canop

https://github.com/user-attachments/assets/877b7ecb-6e44-4d32-8c22-230023e0365e

Its happening in wezterm also, can you try it with more than 15-20 high quality wallpapers and see if it reproduces?

mukul1729 avatar Sep 23 '24 15:09 mukul1729

can you try it with more than 15-20 high quality wallpapers and see if it reproduces?

I'm used to browse directories with thousands of files of several MB. To check it's not a recent bug I just passed over more than a dozen GB of images, with no problem and no decrease in available memory.

Besides such a bug would have been reported before if it was frequent.

Canop avatar Sep 23 '24 17:09 Canop

Oh okay, thanks for making broot tho i use it regularly. One last thing, may i know which linux distro do you use 😀

mukul1729 avatar Sep 23 '24 17:09 mukul1729

I'm usually on debian

Canop avatar Sep 23 '24 18:09 Canop

@mukul1729 Do you by chance have the /tmp folder mounded in RAM ? If so, the last version 1.44.2 should help

Canop avatar Oct 22 '24 09:10 Canop