broot icon indicating copy to clipboard operation
broot copied to clipboard

New install hooks (namely powershell and nushell)

Open melMass opened this issue 3 years ago • 6 comments

The title says it all! I half solved the nushell one and did not look into the powershell one but it should be simple for it too. I can look more into it soonish, creating this ticket as a reminder too.

melMass avatar Oct 31 '22 23:10 melMass

This kind of contribution is very welcome as I don't plan to invest time myself learning nushell or powershell in the near future.

I'll just remember that I want PRs to be focused (don't touch other files or lines), good quality, and that I always need to have testers to confirm the soundness of the approach according to the shell.

Canop avatar Nov 01 '22 06:11 Canop

I can definitely help Quick Start it (and hopefully finish it)

Do I need to know anything besides the single file per shell kind found in? src/shell_install

melMass avatar Nov 01 '22 13:11 melMass

Do I need to know anything besides the single file per shell kind found in? src/shell_install

Well, you'll have to have it called, so you should probably read the whole src/shell_install module and the few lines calling it in src/cli/mod.rs

Canop avatar Nov 01 '22 13:11 Canop

See #159 :)

stinos avatar Dec 13 '22 15:12 stinos

@stinos Nice, thanks for the reminder, I had totally forget about that issue.

Nushell was still in the middle of changing stuffs that would ease this integration. These now shipped in 0.72+ so this can be tackled.

I quickly looked at your PS script and it looks nice, I will have time next week to address the install command of both if no one did by then.

melMass avatar Dec 13 '22 16:12 melMass

@melMass I'll keep an eye for your PR: I just made that script as a one-off and never really looked back but wouldn't mind reviewing it somewhat thoroughly. Like: that dotsource thing looks weird, needs a better implementation or at least a reference to why it's like that

stinos avatar Dec 13 '22 16:12 stinos