WrenAI icon indicating copy to clipboard operation
WrenAI copied to clipboard

chore(wren-ai-service): Refactor Services to use Resource Classes

Open Killer2OP opened this issue 1 year ago • 5 comments

Description

Refactored all the Services to use Resource Class

Fixes #736

Killer2OP avatar Oct 30 '24 19:10 Killer2OP

@paopa @cyyeh Can you please review the PR :)

Killer2OP avatar Oct 30 '24 19:10 Killer2OP

Thank @Killer2OP for your hard work! I'll review this PR later today. It appears there are a few conflicts with the latest changes. Could you please resolve them?

paopa avatar Nov 05 '24 05:11 paopa

Thank you for your contribution! I appreciate the effort you've put into this PR. I have a few remaining comments, and it appears that some tasks are still incomplete. Could you please replace the old classes (such as AskRequest, AskResponse, etc.) in the routers by the input and resource class?

Sure, I will fix them.

Killer2OP avatar Nov 05 '24 14:11 Killer2OP

hey @Killer2OP, hope everything is going smoothly. How's the progress on this PR? Let me know if you need any help. 😄

paopa avatar Nov 11 '24 09:11 paopa

hey @Killer2OP, hope everything is going smoothly. How's the progress on this PR? Let me know if you need any help. 😄

Ya sure 😊 , I was busy due to the exam I will start working on it from today.

Killer2OP avatar Nov 11 '24 15:11 Killer2OP