WrenAI icon indicating copy to clipboard operation
WrenAI copied to clipboard

The data source connection password is empty

Open fredalai opened this issue 1 year ago • 3 comments

Describe the bug

When viewing the Data Source Settings page for a connected MySQL data source, the password field appears empty.

To Reproduce

Steps to reproduce the behavior:

  1. Connect MySQL data source
  2. Go to the Home / Modeling page
  3. Click "Settings" below the sidebar to view the Data Source Settings
  4. See the password field is empty

Expected behavior

Show password placeholder ************ instead of empty when viewing the Data Source Settings.

Screenshots

截圖 2024-10-03 下午2 47 57

Root cause

The Backend API will not return the password field information, so it will become empty if the front end does not process it.

Solution

  • Display the password placeholder ************ instead of leaving the field empty when viewing the Data Source Settings for the following data sources: ClickHouse, MSSQL, MySQL, Postgres, and Trino.

Note: For Postgres data source, it is currently the correct behavior

fredalai avatar Oct 03 '24 07:10 fredalai

Hello @fredalai ! I think i can do this task please can you assign it to me. Thanks.

swarupn17 avatar Oct 03 '24 15:10 swarupn17

Hi, I've added changes to the MySQLProperties.tsx file. I edited line 76, replacing the password placeholder from "input password" to "************".

cubsg avatar Oct 04 '24 00:10 cubsg

@swarupn17, it looks like @cubsg has been working on this issue and also submitted a PR. Can you look into other issues that you might be interested in? Thanks!

chilijung avatar Oct 04 '24 02:10 chilijung

Hi, it seems like there's an error showing up when clicking on the save button of Data Source Settings page for my connected Postgres data source even though I didn’t modify any settings from the initial setup phase. For reference, I’m using SQLite as the database for my Wren-UI, and the Wren AI version is 0.8.1. Your help is very much appreciated!

Screenshot

Console output

Log output

image

ongdisheng avatar Oct 21 '24 13:10 ongdisheng

Hi @ongdisheng,

Thanks for catching that issue—it’s a bug. https://github.com/Canner/WrenAI/issues/800

Thanks, Freda

fredalai avatar Oct 23 '24 01:10 fredalai

Hi @fredalai, I noticed there hasn’t been much progress on the previous PR. Would it be alright if I step in and submit my own PR to help move things forward?

ongdisheng avatar Oct 23 '24 05:10 ongdisheng

@ongdisheng Yep, sure. reassigned.

fredalai avatar Oct 24 '24 01:10 fredalai