WrenAI icon indicating copy to clipboard operation
WrenAI copied to clipboard

[Feature Request] Support composite foreign key for table's relationship definition

Open iAgiler opened this issue 8 months ago • 8 comments

Current, when we trying to add a new relationship, WrenAI UI only support from one field to one field. But composite foreign key is not the rare case.

It is better to support specifying from multiple fields to multiple fields in adding new relationship UI. Thanks.

Image

iAgiler avatar Jun 11 '25 08:06 iAgiler

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

github-actions[bot] avatar Sep 06 '25 05:09 github-actions[bot]

I have read the CLA Document and I hereby sign the CLA

Ajay-Satish-01 avatar Sep 06 '25 05:09 Ajay-Satish-01

It looks like there are many noises to your last commit, related to code formating.

I don't think we apply such rules in the project lint configuration (we use eslint).

Hi,

I ran the eslint lint commands in package.json and checked for documentation regarding code formatting. These do not fix the prettier styles my local machine uses. Do you have any other tools I might be missing?

Ajay-Satish-01 avatar Sep 15 '25 15:09 Ajay-Satish-01

I ran the eslint lint commands in package.json and checked for documentation regarding code formatting.

@Ajay-Satish-01 What are the commands you run for that?

Do you have any other tools I might be missing?

I think there's only eslint for the JS code.

fflorent avatar Sep 15 '25 17:09 fflorent

I ran the eslint lint commands in package.json and checked for documentation regarding code formatting.

@Ajay-Satish-01 What are the commands you run for that?

Do you have any other tools I might be missing?

I think there's only eslint for the JS code.

Oh. Should I include TS then? Or will that be a separate issue?

Ajay-Satish-01 avatar Sep 17 '25 00:09 Ajay-Satish-01

Should I include TS then? Or will that be a separate issue?

Sorry, I meant the TypeScript code.

fflorent avatar Sep 17 '25 20:09 fflorent

Just so the whitespace/formatting issue is clear, take a look at what a reviewer will see:

https://github.com/gristlabs/grist-core/pull/1818/files

Remember they have to review all changes, no skipping - make sure to click to expand files with many changes.

Reviewers can tell github or git to hide whitespace changes, but they are still a problem once they are landed and accepted, since any other people working on the same files will now have unnecessary conflicts to resolve.

paulfitz avatar Nov 08 '25 14:11 paulfitz

Just so the whitespace/formatting issue is clear, take a look at what a reviewer will see:

https://github.com/gristlabs/grist-core/pull/1818/files

Remember they have to review all changes, no skipping - make sure to click to expand files with many changes.

Reviewers can tell github or git to hide whitespace changes, but they are still a problem once they are landed and accepted, since any other people working on the same files will now have unnecessary conflicts to resolve.

Hi,

Do you know if you have a default formatter or any config present? like prettier or biome? Every change I make has formatting issues.

Ajay-Satish-01 avatar Nov 10 '25 00:11 Ajay-Satish-01