WrenAI icon indicating copy to clipboard operation
WrenAI copied to clipboard

chore(wren-ai-service): improve chart generation

Open cyyeh opened this issue 11 months ago • 2 comments

add multi-line chart

Summary by CodeRabbit

  • New Features

    • Added support for multi-line chart type across chart generation and adjustment services
    • Enhanced chart generation instructions to include multi-line chart requirements
  • Improvements

    • Refined system prompts for chart generation and adjustment
    • Tightened reasoning requirements in chart generation prompts
    • Updated input context for data analyst visualization
  • Technical Updates

    • Expanded chart type options in multiple service classes
    • Updated type definitions to include "multi_line" chart type

cyyeh avatar Jan 10 '25 07:01 cyyeh

[!WARNING]

Rate limit exceeded

@cyyeh has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 9 minutes and 37 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 019e8a49db53ad821e6f54fcc78c9922bd237935 and 849a6c8214aecaf7e6bf01e649b7d24e1dc10e1d.

📒 Files selected for processing (3)
  • wren-ai-service/src/pipelines/generation/utils/chart.py (6 hunks)
  • wren-ai-service/src/web/v1/services/chart.py (1 hunks)
  • wren-ai-service/src/web/v1/services/chart_adjustment.py (2 hunks)

Walkthrough

The pull request introduces a new chart type called "multi_line" across multiple files in the Wren AI service. This change involves updating system prompts, chart generation instructions, and type definitions to support multi-line charts. The modifications primarily focus on expanding the chart type options in various components of the chart generation and adjustment systems, ensuring consistent support for the new chart visualization type.

Changes

File Change Summary
src/pipelines/generation/chart_adjustment.py Updated system prompt to broaden input context and add multi-line chart type
src/pipelines/generation/chart_generation.py Modified system prompt and expanded chart type options
src/pipelines/generation/utils/chart.py Added "Multi line chart" instructions and updated ChartGenerationResults type
src/web/v1/services/chart.py Updated ChartResult to include "multi_line" chart type
src/web/v1/services/chart_adjustment.py Added "multi_line" to ChartAdjustmentOption and ChartAdjustmentResult

Sequence Diagram

sequenceDiagram
    participant User
    participant ChartGeneration
    participant DataAnalyst
    participant ChartAdjustment

    User->>ChartGeneration: Request chart with data
    ChartGeneration->>DataAnalyst: Generate chart schema
    DataAnalyst-->>ChartGeneration: Return multi-line chart schema
    ChartGeneration->>ChartAdjustment: Propose chart adjustment
    ChartAdjustment->>DataAnalyst: Refine chart if needed
    DataAnalyst-->>ChartAdjustment: Return adjusted multi-line chart
    ChartAdjustment->>User: Present final chart

Possibly related PRs

  • #1079: Enhances chart generation functionality by adding chart_type field.
  • #1080: Ensures correct display of chart properties in the UI.

Suggested labels

module/ui

Suggested reviewers

  • paopa

Poem

🐰 A rabbit's chart adventure begins anew,
Multi-lines dancing, data's vibrant hue!
From single threads to complex weave,
Our visualization now can achieve
A story told in graphical delight! 📊


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar Jan 10 '25 07:01 coderabbitai[bot]

There are still some parts missing according to the Ai code review, I will add them later so I make the PR as draft

cyyeh avatar Jan 13 '25 05:01 cyyeh

LGTM! leave a question comment only.

if chart is invalid, the chart type is empty string

cyyeh avatar Jan 14 '25 01:01 cyyeh

LGTM! leave a question comment only.

if chart is invalid, the chart type is empty string

can you mention the thing in codebase, i think it will good for members to know, thanks!

paopa avatar Jan 14 '25 02:01 paopa