obsidian-janitor icon indicating copy to clipboard operation
obsidian-janitor copied to clipboard

[Feature Request] Consider .canvas file and other files used inside the canvas not being orphans

Open onlyice opened this issue 2 years ago • 7 comments

Currently, the plugin consider .canvas files and assets inside them as orphans. It would be helpful to not consider them as orphans.

Thanks for this wonderful plugin!

onlyice avatar Jan 03 '23 12:01 onlyice

Makes sense, I still need to work on canvas support.

Canna71 avatar Jan 06 '23 11:01 Canna71

Canvas support is tricky at the moment. Please try release 1.1.0 (you could install it with BRAT) in which I added some experimental support for canvas

Canna71 avatar Jan 08 '23 17:01 Canna71

Thanks! I'll try it out as soon as possible.

onlyice avatar Jan 09 '23 06:01 onlyice

Hi! I really like this plugin and thanks a lot for your work. I tried version 1.1.0 but it is still removing my pictures inside a canvas file.

DDDOH avatar Apr 04 '23 15:04 DDDOH

Thank you for this great plugin. If you have some time, could you look into improving the canvas support? It looks like it's possible as others have code to scan images used in a canvas: https://github.com/sandorex/nuke-orphans-plugin/commit/94b49fd959f2c6dc98f195ec7744b0e0cf4aebd5. Thanks again for your work.

tht avatar Aug 21 '23 19:08 tht

Echo on this. This is a wonderful plugin. It would be nice if the canvas issue could be fixed. Thank you so much!

OkamiWong avatar Aug 25 '23 02:08 OkamiWong

After some testing I can say that version 1.1.0 is working for me. It recognised all the images in a canvas correctly, with one exception. Group background images are not detected and marked 'orphaned'. So if this is not a problem for you (as it is not for me...), just use version 1.1.0.

tht avatar Aug 25 '23 10:08 tht