Android-Image-Cropper icon indicating copy to clipboard operation
Android-Image-Cropper copied to clipboard

[BUG] - Setting toolbar color to White does nothing

Open Devenom1 opened this issue 1 year ago • 1 comments

  • Lib Version [4.3.2]

Describe the bug

Setting the toolbar color to Color.WHITE doesn't work.

This happens because of a condition checking if toolbar color is -1 assume it's not set. Unfortunately -1 is also the value of Color.WHITE.

PS: I had made this feature. Will fix it

To Reproduce

Steps to reproduce the behavior:

  1. Use the setToolbarColor method to set the toolbar color to white. The method will be setToolbarColor(Color.WHITE)

Expected behavior The toolbar should change to white but it doesn't happen

Media image

Notice how the toolbar color is still purple and not changed to white

Smartphone (please complete the following information):

  • Any Device

Additional context I think we will need to add options to change toolbar title color and the toolbar back button and other toolbar text

Devenom1 avatar Sep 09 '22 13:09 Devenom1

Let's keep this mess organised! This issue has been automatically marked as stale because it has not had recent activity. =( It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Sep 24 '22 02:09 stale[bot]