Use new Perl icons for file types

[jreznot]

Hi, here we change icons for scripts and modules to new SVG icon

Summary by CodeRabbit

• Refactor
  • Updated the Perl file icons to use a centralized, standard design for enhanced visual consistency across the application.

[coderabbitai[bot]]

Walkthrough

The change updates the icon declarations in the PerlIcons class. Instead of loading icons via a method call with specific file paths, the code now directly assigns the AllIcons.FileTypes.Perl constant to both the PM_FILE and PERL_SCRIPT_FILE_ICON variables. This centralizes icon management and removes the previous reliance on file path strings.

Changes

File	Change Summary
plugin/core/.../PerlIcons.java	Updated PM_FILE and PERL_SCRIPT_FILE_ICON declarations to use AllIcons.FileTypes.Perl instead of the load() method with explicit resource paths.

Poem

Hop along with code so bright,
My whiskers twitch with pure delight.
Icons now shine with constant grace,
No more file paths to chase.
A rabbit cheers with every byte!

---

📜 Recent review details

Configuration used: CodeRabbit UI Review profile: CHILL Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0821fedb4382f47d02b539aa19749af731e1a74b and a4f8cb8f5d3bf2a98456007f930a9552215de037.

📒 Files selected for processing (1)

• plugin/core/src/main/java/com/perl5/PerlIcons.java (2 hunks)

🔇 Additional comments (2)

plugin/core/src/main/java/com/perl5/PerlIcons.java (2)

20-20: LGTM!

The import of AllIcons is necessary for accessing the new Perl file type icon.

---

46-47: Verify the use of identical icons for both file types.

The change improves maintainability by using platform icons and provides better HiDPI support through SVG. However, previously PM files and Perl scripts had distinct icons (perl5.png vs perl5classic.png). Please confirm if using the same icon for both file types is intentional, as it might reduce visual distinction between them.

Run this script to check the historical context of these icons:

❌ Verification inconclusive

🏁 Script executed:

#!/bin/bash
# Description: Check the history of icon usage to understand the distinction between PM and Perl script icons

# Check git history for the removed icon files
git log --all -- "**/perl5.png" "**/perl5classic.png"

# Check for any related discussions in commit messages
git log --grep="icon" --grep="perl5" --grep="file.*type" -i

Length of output: 0

---

Confirm that using the same platform icon for both PM files and Perl scripts is intentional.

The recent history search did not return any commit messages or discussion context regarding the change, so we cannot definitively conclude whether converging to a single SVG icon was planned or accidental. Please verify manually that this change aligns with your design intentions.

✨ Finishing Touches

• [ ] 📝 Generate Docstrings (Beta)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[hurricup]

I need to distinct different files (scripts/pms), they should have different icons.

[jreznot]

We can create couple of those with different color from palette

[hurricup]

would be nice. There should be an issue about creating new icons for the plugin. (in the youtrack)