Stop codons are usually "*" not "x"

Open Koeng101 opened this issue 3 years ago • 3 comments

https://github.com/CamelCaseCam/CadBerry/blob/36dad3c8c382a2da26ca78d61ff2a99aaf7310f2/CadBerry/GILBuildEngine/src/GIL/Compiler/CodonEncoding.cpp#L74-L76

Small nitpick : stop codons are usually represented with "*", not "x"

Oct 18 '22 23:10 Koeng101

That's actually fair. Note to self: add support for * in an amino sequence

Oct 18 '22 23:10 CamelCaseCam

I think I chose 'x' because '*' could have its own special meaning in the language, but I'd only been doing synbio for a month when I started the C# version of this project, so it might have been stylistic

Oct 18 '22 23:10 CamelCaseCam

Completely forgot about this, but I looked into it and it's an easy fix. GIL has support for non-canonical amino acids, so I'll just add a * key to the gilEncoding files so you can use either. This should be out with the next bool release!

Jan 30 '23 21:01 CamelCaseCam