FTorch icon indicating copy to clipboard operation
FTorch copied to clipboard

Add conda CI

Open jfdev001 opened this issue 3 months ago • 2 comments

Another thing that would be nice, I guess, would be to add some conda CI. Though I accept this is a bigger task and would require a separate PR

Originally posted by @jatkinson1000 in #430

jfdev001 avatar Sep 24 '25 09:09 jfdev001

Could possibly use the matrix concept to support different build approaches within a single workflow definition, along with spack and fpm (to be added in #271, #429).

joewallwork avatar Sep 24 '25 10:09 joewallwork

Per https://github.com/Cambridge-ICCS/FTorch/issues/430#issuecomment-3327443710 during CMAKE_BUILD_TESTS, a check should be added for the CONDA_PREFIX since currently there is a check for VIRTUAL_ENV (which could be set as something like export VIRTUAL_ENV=$(pwd)/.venv/bin if using venv) as in

https://github.com/Cambridge-ICCS/FTorch/blob/f230be8983a0280893168a6a820b2f8f4f568e81/CMakeLists.txt#L169

but we should also catch conda envs too by changing it to

if(NOT DEFINED ENV{VIRTUAL_ENV} AND NOT DEFINED ENV{CONDA_PREFIX})

~This change really only becomes relevant once conda is included in the CI, though.~

jfdev001 avatar Sep 24 '25 16:09 jfdev001