lifelines icon indicating copy to clipboard operation
lifelines copied to clipboard

Weibull fitter has different results for the same data and environment

Open GergelyMincsovicsPhilips opened this issue 3 years ago • 1 comments

Weibull fitter and Weibull AFT with no features have different results for the same data #750 #750 is closed, while I am still observing the issue on 0.26.4, even when not changing anything in the environment. Was it fixed? If not, would you point me to the piece that calls the optimization for the Weibull fitter?

Hi @GergelyMincsovicsPhilips, I don't think anything changed as a result of #750. Are you able to post the parameter estimates (using .print_summary() or something) for the two models.

The optimization code for the Weibull Fitter is here

CamDavidsonPilon avatar Sep 08 '22 01:09 CamDavidsonPilon

it turned out that the differences I saw come from the order I called the Weibull, looping over the groups, i.e.

BEFORE (changes in the output observed) Groups=df['G'] for group in set(Groups):

AFTER (stable output) Groups=df['G'] for group in sorted(set(Groups)):

the issue can be closed