Cameron Davidson-Pilon
Cameron Davidson-Pilon
Thanks @ah-sadek!
You will probably have to try an evaluation metric outside of lifelines. The brier score is one such metric, and I would be happy to see that contributed to lifelines!
Hm, I don't think you can, sorry @MatGodRho. FYI, there is a trend to move away from log-rank tests though, see comments here: https://discourse.datamethods.org/t/when-is-log-rank-preferred-over-univariable-cox-regression/2344
This is what is recommended ^ The p-values might be different (they are measuring different things), but in both cases you are testing a detectable difference in hazards.
Hi @orah1998 , I could suggest using a forum like [crossvalidated.com](https://stats.stackexchange.com/) to ask / search questions about what statistical values mean. These concepts aren't unique to lifelines either, and are...
The code look reasonable, and I can't spot a problem by looking at it. I'm going to pull this locally to see if I can figure it out. BTW -...
Also PR workflow is perfect
Looks reasonable! But the proof is in the unit test :) I'd appreciate a PR - we can work together on this from there.
Hi @griffiri - are you trying to create a PR from your own fork? Usually the workflow is: 1. [Fork](https://docs.github.com/en/github/getting-started-with-github/fork-a-repo) this repo to under your own account 2. Git clone...
Hi @JamesPHoughton The only thing I can suggest is to use the `cluster_col` arg (similar to the `cluster` in R's survival). https://lifelines.readthedocs.io/en/latest/Examples.html#correlations-between-subjects-in-a-cox-model