Five-Fifths-Voter icon indicating copy to clipboard operation
Five-Fifths-Voter copied to clipboard

Text doesn't appear on Android app

Open cstefano1 opened this issue 3 years ago • 4 comments

Describe the bug The text "5/5 equals a whole. A whole person…" doesn’t appear on the mobile app

To Reproduce Steps to reproduce the behavior:

  1. Go to mobile app
  2. Notice missing text

Expected behavior I presume the text should be there.

Screenshots Screenshot of web app: image Screenshot of mobile app: image

Smartphone (please complete the following information):

  • Device: Samsung S10+
  • OS: Android
  • Browser: N/A (on mobile app)
  • Version 11

Additional context Add any other context about the problem here.

cstefano1 avatar Oct 28 '21 23:10 cstefano1

Thank you @cstefano1 for creating this issue. I had not noticed. Anything under 1056px, the text is taken out as the display is set to none. I am guessing this was a design decision taken when the code was written. @davidnixon @sebastianhuynh-nyc probably know more.

https://github.com/Call-for-Code-for-Racial-Justice/Five-Fifths-Voter/blob/4515dc4e6beef5fbc32c724e7ac28d5cd2388733/ui/src/components/Hero/_hero.scss#L210

.hero__description {
  @include carbon--type-style('productive-heading-03');
  display: none;
  max-width: 630px;
  margin-bottom: $spacing-06;

  @media (min-width: 1056px) {
    display: block;
  }
}

upkarlidder avatar Nov 09 '21 02:11 upkarlidder

:wave: Hi! This issue has been marked stale due to inactivity. If no further activity occurs, it will automatically be closed.

github-actions[bot] avatar Dec 10 '21 01:12 github-actions[bot]

Closed by bot; I'm reopening.

cstefano1 avatar Jan 10 '22 18:01 cstefano1

:wave: Hi! This issue has been marked stale due to inactivity. If no further activity occurs, it will automatically be closed.

github-actions[bot] avatar Apr 20 '24 00:04 github-actions[bot]