Five-Fifths-Voter
Five-Fifths-Voter copied to clipboard
Text doesn't appear on Android app
Describe the bug The text "5/5 equals a whole. A whole person…" doesn’t appear on the mobile app
To Reproduce Steps to reproduce the behavior:
- Go to mobile app
- Notice missing text
Expected behavior I presume the text should be there.
Screenshots
Screenshot of web app:
Screenshot of mobile app:
Smartphone (please complete the following information):
- Device: Samsung S10+
- OS: Android
- Browser: N/A (on mobile app)
- Version 11
Additional context Add any other context about the problem here.
Thank you @cstefano1 for creating this issue. I had not noticed. Anything under 1056px, the text is taken out as the display is set to none
. I am guessing this was a design decision taken when the code was written. @davidnixon @sebastianhuynh-nyc probably know more.
https://github.com/Call-for-Code-for-Racial-Justice/Five-Fifths-Voter/blob/4515dc4e6beef5fbc32c724e7ac28d5cd2388733/ui/src/components/Hero/_hero.scss#L210
.hero__description {
@include carbon--type-style('productive-heading-03');
display: none;
max-width: 630px;
margin-bottom: $spacing-06;
@media (min-width: 1056px) {
display: block;
}
}
:wave: Hi! This issue has been marked stale due to inactivity. If no further activity occurs, it will automatically be closed.
Closed by bot; I'm reopening.
:wave: Hi! This issue has been marked stale due to inactivity. If no further activity occurs, it will automatically be closed.