lineupjs icon indicating copy to clipboard operation
lineupjs copied to clipboard

Unify dialog interaction by removing the apply and cancel buttons

Open thinkh opened this issue 6 years ago • 3 comments

At the moment the interaction of the dialogs differ a lot from each other. For instance, the change visualization dialog applies changes immediately, where as the mapping dialog applies a preview immediately, but the user has to choose between cancel, reset and apply. That is confusing and should be unified.

change visualization dialog

image

I suggest that we remove the apply and cancel button and apply the changes in all dialogs immediately. Only for some complex dialogs (e.g. the mapping dialog a reset button) is helpful to restore the initial state.

thinkh avatar Feb 01 '18 08:02 thinkh

some operations are expensive. including filtering and searching. So applying everything immediately when the user enters something can be costly.

sgratzl avatar Feb 01 '18 08:02 sgratzl

but that does not change the fact that it is inconsistent at the moment. for instance, we already apply costly transformations (e.g., invert) immediately (sometimes even although there is a apply button). my feeling is that we should always apply actions immediately - even if it takes some time (it's usually below 1s though).

mstreit avatar Feb 01 '18 09:02 mstreit

In addition to @mstreit comment: We can also show a spinner/loading icon while the change is applied.

thinkh avatar Feb 01 '18 10:02 thinkh