joplin-math-mode icon indicating copy to clipboard operation
joplin-math-mode copied to clipboard

Published 20 hours ago • verified publisher icon CalebJohn

ADD: Math View

Open xtulnx opened this issue 3 years ago • 5 comments

Hi，I like your plugin : 'joplin-math-mode' .

This is my first PR. Hope it helps you. Thanks.

Some problems are not solved ,such as 'Global State' , and 'Unit support'.

xtulnx avatar Apr 26 '21 09:04 xtulnx

@xtulnx thanks for the pull request. I haven't forgotten it but i won't be able to review it for at least a couple more days. I'm excited about the changes you've made and i look forward to integrating them into the plugin.

CalebJohn avatar Apr 29 '21 18:04 CalebJohn

Hi @xtulnx

I've looked over your changes again and I'm really impressed! It looks awesome. I do have some changes I would like to make before merging this. Do you mind if I make the changes or would you prefer for me to list them and have you make the changes? Basically I would like the remove the duplicate code between modules and make the editor and the viewer more consistent.

CalebJohn avatar May 01 '21 23:05 CalebJohn

Yes, you can deal with it as needed.

xtulnx avatar May 06 '21 08:05 xtulnx

Hi. I know this is a very old thread but I was wondering if you ever got around to reviewing/amending this PR? It would be great to have this merged.

littlegraycells avatar Nov 28 '23 18:11 littlegraycells

@xtulnx this looks amazing! Thank you for implementing this.

limdingwen avatar Feb 02 '24 15:02 limdingwen