fluids icon indicating copy to clipboard operation
fluids copied to clipboard

Published 20 hours ago • verified publisher icon CalebBell

Feature request: DN pipe EN 10255

Open rddaz2013 opened this issue 6 years ago • 2 comments

Hi,

nice tool great work

Is it possible to implement a further pipe diameter type? aka EN10255

rddaz2013 avatar Feb 21 '18 14:02 rddaz2013

Hi Rene,

Thanks! Sure it would be possible for someone to add another pipe schedule to fluids. I know there are lots more standards, like for PVC, ABS, cooper tube, and the standards used in different countries. I agree it would be a good feature. I don't have it on my agenda for the moment, but would be happy to merge a good PR with tests. Alternatively, next time I revisit nearest_pipe (if I did get around to increasing the number of supported pipe standards), I would only be able to include EN10255 if I had a copy of the standard as well.

Cheers, Caleb

CalebBell avatar Feb 22 '18 04:02 CalebBell

I think i could prepare the EN10255 addition, i see into the pipe.py. If it is done i make a pull-request.

rddaz2013 avatar Feb 22 '18 09:02 rddaz2013