cakephp3-bootstrap-helpers icon indicating copy to clipboard operation
cakephp3-bootstrap-helpers copied to clipboard

Published 20 hours ago • verified publisher icon CakePHP-Bootstrap

CakePHP 4 support

Open Erwane opened this issue 5 years ago • 6 comments

I'm using this plugin since years now and i want to create a PR to support Cakephp4 with bootstrap4.

From which branch should i start please ?

Erwane avatar Feb 03 '20 09:02 Erwane

You should start with the https://github.com/Holt59/cakephp3-bootstrap-helpers/tree/v4.0.3 branch.

Holt59 avatar Feb 03 '20 10:02 Holt59

Thanks, i'm on it.

I'm looking the project name and versions and do you plan to rename it "cakephp-bootstrap-helpers" and think about a notation branchs for versions ? cake3-bootstrap3, cake3-bootstrap4, cake4-bootstrap4 ?

Erwane avatar Feb 10 '20 10:02 Erwane

in progress : https://github.com/Erwane/cakephp3-bootstrap-helpers/tree/cake4-compatibility

Erwane avatar Mar 05 '20 15:03 Erwane

@Erwane Thanks for all the work!

I have to check what implies a renaming of the Github project, I think Github can provide a redirection to the new project from the old URL but I'd have to check.

For the version, it's a bit more complicated unfortunately... For the branch names, there are currently no issues, but for composer to work properly there are some constraints on tagging (e.g., if you want 3.2.* or something like that).

Holt59 avatar Mar 06 '20 13:03 Holt59

Proposal :

  • 3.3.x.y : cake 3, Bs 3
  • 3.4.x.y : cake 3, Bs 4
  • 4.4.x.y : cake 4, Bs 4

We only have "patch" (x) and "release" (y) numbers for new helpers or fixes.

In composer : composer require holt59/cakephp-bootstrap:"^3.4.0" for cake 3 with bootstrap 4

Erwane avatar Mar 06 '20 13:03 Erwane

@Erwane Yes, I think it's the best idea. And it does not break current versions which is a good thing. I will try to move everything to the new scheme this week-end and update the README(s) accordingly.

Holt59 avatar Mar 06 '20 13:03 Holt59