hugo-theme-stack icon indicating copy to clipboard operation
hugo-theme-stack copied to clipboard

fix waline placeholder parameter

Open L-Super opened this issue 2 years ago • 1 comments

  1. fix placeholder location
  2. update url

reference: https://waline.js.org/en/cookbook/customize/locale.html

L-Super avatar Nov 30 '23 03:11 L-Super

By the way, It seems that there is no visitor .

L-Super avatar Nov 30 '23 03:11 L-Super

By the way, It seems that there is no visitor .

Yes, that must have been removed as well. If you find out what the new key of this option is, please open a new PR.

CaiJimmy avatar Mar 02 '24 22:03 CaiJimmy

By the way, It seems that there is no visitor .

Yes, that must have been removed as well. If you find out what the new key of this option is, please open a new PR.

The change seems to be a bit big, it can't simply implement the corresponding function through add and delete key. So, can you fix it? @CaiJimmy refer: https://waline.js.org/en/guide/features/pageview.html

https://waline.js.org/en/guide/features/comment.html

L-Super avatar Mar 05 '24 03:03 L-Super

Actually, there's a bigger issue: the current version of Waline included within this theme is v2: https://github.com/CaiJimmy/hugo-theme-stack/blob/4948a3723e42fb775f4d895e4d173c5521be81b9/layouts/partials/comments/provider/waline.html#L1-L2

CaiJimmy avatar Mar 10 '24 19:03 CaiJimmy

Actually, there's a bigger issue: the current version of Waline included within this theme is v2:

https://github.com/CaiJimmy/hugo-theme-stack/blob/4948a3723e42fb775f4d895e4d173c5521be81b9/layouts/partials/comments/provider/waline.html#L1-L2

Could you upgrade to the latest version?

L-Super avatar Mar 11 '24 03:03 L-Super

Actually, there's a bigger issue: the current version of Waline included within this theme is v2: https://github.com/CaiJimmy/hugo-theme-stack/blob/4948a3723e42fb775f4d895e4d173c5521be81b9/layouts/partials/comments/provider/waline.html#L1-L2

Could you upgrade to the latest version?

No, I don't use Waline and can't test if there are any compatibility issues with v3.

CaiJimmy avatar Mar 13 '24 22:03 CaiJimmy