sodium-fabric icon indicating copy to clipboard operation
sodium-fabric copied to clipboard

Option to make lilypads render with the same rotation as in vanilla minecraft

Open Jeroen-45 opened this issue 4 years ago • 2 comments

Is your feature request related to a problem? Please describe. The rotation that lilypads are rendered in is inconsistent with the vanilla version of minecraft. This, for example, makes it difficult to use lilypads for hiding (or finding) secret codes that use this location-specific rotation. I have been told this discrepancy is caused by Sodium using a different random source for randomized block rotations.

Describe the solution you'd like It would be useful to have the option to disable this specific optimization.

Describe alternatives you've considered A more general option to choose which random source to use would also help.

Jeroen-45 avatar Oct 29 '20 22:10 Jeroen-45

Is this still an issue? With 1.19, everything uses the vanilla Random.

IMS212 avatar Aug 24 '22 17:08 IMS212

I just checked, and it appears that the lilypads are still rendered with rotations different to vanilla in 1.19.2. Perhaps interesting is that the rotations with sodium have changed from 1.18.2 to 1.19.2, while the vanilla rotations are still the same between versions. I have tested this with a superflat water world with the top layer set to lilies in both versions with and without sodium, you can view the results below:

1.18.2 Vanilla: 1 18 2 Vanilla

1.18.2 Fabric + Sodium: 1 18 2 Fabric + Sodium

1.19.2 Vanilla: 1 19 2 Vanilla

1.19.2 Fabric + Sodium: 1 19 2 Fabric + Sodium

I found that the best way to view the differences is to compare a specific row or column, or to open them in an image viewer and switch back and forth.

Jeroen-45 avatar Aug 24 '22 18:08 Jeroen-45

It appears this issue has been fixed as of https://github.com/CaffeineMC/sodium-fabric/commit/c7a584286ff99241f1f08875976e7a496829cdac.

Vanilla: image

Sodium: image

FlashyReese avatar Jul 10 '23 23:07 FlashyReese