sodium-fabric icon indicating copy to clipboard operation
sodium-fabric copied to clipboard

Add Fast Leaves setting

Open SAPET123 opened this issue 4 years ago • 10 comments

Please add a setting to video settings that would let you play with graphics set fast bet your leaves would be set to fancy. You can do that with optifine and it would be really cool in my opinion to set my leaves to fancy but everything other would be set to fast. If its possible please add this to the video settings

SAPET123 avatar Aug 04 '20 12:08 SAPET123

Sodium already does this. Leaves will always be transparent whether you have graphics set to "Fast", "Fancy" or "Fabulous". Sodium greatly improves the rendering technique of leaves, to the point that transparency is negligible.

amnotbananaama avatar Aug 04 '20 15:08 amnotbananaama

Sodium already does this. Leaves will always be transparent whether you have graphics set to "Fast", "Fancy" or "Fabulous". Sodium greatly improves the rendering technique of leaves, to the point that transparency is negligible.

Ok but I do I turn it on cuz I downloaded sodium this morning and when I have my graphics set to fast the leaves are still fast and not transparent. Was there some new update where they have made it like that?

SAPET123 avatar Aug 04 '20 17:08 SAPET123

I think the behaviour described by amnotbananaama may be a bug, or may be a feature, but it's only in development builds which are a bit broken currently. Regardless of whether this request should be implemented, I do have a workaround for you. After some brief wiki searching, I think the difference between fast/fancy is very limited, it's only: weather, clouds, leaves and maybe vignette. Since the other three options can be toggled independently in Sodium, you can simply set your graphics to fancy for the leaves then turn these other options down.

Adding a toggle for leaves would match the other settings, but seems a bit redundant, unless someone wants to use fast leaves with fabulous graphics?

LucilleTea avatar Aug 04 '20 17:08 LucilleTea

Thank you for your respond. I appreciate it.

Dňa ut, 4. aug 2020, 19:17 Lucy-t [email protected] napísal(a):

I think the behaviour described by amnotbananaama may be a bug, or may be a feature, but it's only in development builds which are a bit broken currently. Regardless of whether this request should be implemented, I do have a workaround for you. After some brief wiki searching, I think the difference between fast/fancy is very limited, it's only: weather, clouds, leaves and maybe vignette. Since the other three options can be toggled independently in Sodium, you can simply set your graphics to fancy for the leaves then turn these other options down.

Adding a toggle for leaves would match the other settings, but seems a bit redundant, unless someone wants to use fast leaves with fabulous graphics?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/jellysquid3/sodium-fabric/issues/233#issuecomment-668721592, or unsubscribe https://github.com/notifications/unsubscribe-auth/APEYIUAWV7EMRN2DWWYUAKTR7A7EBANCNFSM4PUKVCVQ .

SAPET123 avatar Aug 04 '20 17:08 SAPET123

Sodium already does this. Leaves will always be transparent whether you have graphics set to "Fast", "Fancy" or "Fabulous".

I don't believe this is true.

  • Minecraft 1.16.4
  • Fabric 0.11.1
  • Sodium 0.1.0
  • Multidraw (GL 4.3)
  • Radeon HD 7570M
  • Fedora Linux 31
  • Java: 11.0.9.1+11(OpenJDK)
    • Also occurs on Mojang Java

2021-01-16_10 48 37

Bundled JVM: 2021-01-16_10 52 24

(Yes, I know the FPS are extremely low in these screenshots — they stabilize around 75–90 once the game is fully loaded)

JamesTheAwesomeDude avatar Jan 16 '21 17:01 JamesTheAwesomeDude

For my part, I use Cull Leaves to "fix" this issue, It's entirely compatible with Sodium.

MrTechyyy avatar Jan 16 '21 18:01 MrTechyyy

I don't believe this is true.

It was true at the time I made that comment, more than 5 months ago. Since then, it seems that the behavior has changed in current development builds.

Given that this functionality is available in another mod, I don't think this feature would be a good fit in Sodium at this time.

amnotbananaama avatar Jan 18 '21 23:01 amnotbananaama

Given that this functionality is available in another mod,

@amnotbananaama Which other mod are you referring to?

For my part, I use Cull Leaves to "fix" this issue,

@MrTechyyy "Cull Leaves" does not provide this functionality:

  • Minecraft 1.16.5
  • Fabric 0.11.1
  • Sodium 0.1.0
  • Cull Leaves 2.0.0

2021-01-26_14 35 06

I don't think this feature would be a good fit in Sodium at this time.

On the contrary, I believe Leaves would fit in perfectly, next to Clouds and Weather in the section for overriding aspects of Fast vs Fancy graphics. (There are others, but Leaves is the most important QoL fix; it was the only one I really valued being able to manipulate in OptiFine)

JamesTheAwesomeDude avatar Jan 26 '21 21:01 JamesTheAwesomeDude

this feature is available in 1.17 dev but is there any way to turn off transparent leaves

Rajbir98 avatar Jun 21 '21 07:06 Rajbir98

This can be closed now I think, they added the setting.

Lentern avatar Aug 31 '22 01:08 Lentern

Fast leaves are opaque in 0.4.11 this is resolved.

MeeniMc avatar May 11 '23 01:05 MeeniMc