Block model cuboids and their textures are misaligned compared to vanilla

[WeegeeTheDoggo]

Bug Description

Expected: Block models and textures to line up as they normally do in vanilla

Actual: Block models and textures are slightly out of line

I believe this to be a bug. It does not happen with any other mods, or just by using Fabric itself, or in vanilla. I'm not aware of a setting that could remedy this, after looking through all the in-game settings for Sodium and testing each one. This bug affects an unknown number of block models, but I can verify it in end rods, torches, and fences. I expect that it affects many more.

Normal: Using Sodium:

Reproduction Steps

• Make sure fabric-loader-0.14.21-1.20.1 is installed
• Download fabric-api-0.86.0+1.20.1 and sodium-fabric-mc1.20-0.4.10+build.27 and place them into the mods folder
• Launch Minecraft Launcher
• Select fabric-loader-0.14.21-1.20.1 profile
• Wait for game to load, then enter a world and look closely at block model (such as end rod) (use spectator mode if needed)

Log File

latest.log

Crash Report

crash-2023-07-22_07.39.29-client.txt

[pajicadvance]

I can reproduce this on my system.

[muzikbike]

Vanilla has its own alignment issues with models as well. (#1316)

I wonder if it'd be possible for Sodium to fix this issue and the vanilla cases as well (#1607). There exist mods such as Model Gap Fix and Model Fix Multi which resolve vanilla's issues with this, so integrating such a fix into Sodium as well so that more people can benefit would be a nice touch.

[jellysquid3]

We can't really fix any of these vertex precision issues until the fluid renderer is rewritten to not abuse them. At that point, it should become possible to correct the off-by-one issue which affects texture coordinates, since it won't cause texture gaps in fluid rendering.

[jellysquid3]

The issue described here should be fixed with https://github.com/CaffeineMC/sodium-fabric/commit/ea0172768a5da9907b5a5711160dc3984fafea83.