phosphor-fabric icon indicating copy to clipboard operation
phosphor-fabric copied to clipboard

[Question] 1.20 ?

Open HowardZHY opened this issue 1 year ago • 10 comments

Will it update to 1.20?

HowardZHY avatar Jun 09 '23 18:06 HowardZHY

1.20 dramatically improved the performance of the lighting engine. There hasn't been an official yes or no as to whether phosphor will be updating, but I wouldn't bet on it at this time

TheUserCreated avatar Jun 09 '23 19:06 TheUserCreated

1.20 vanilla is basically a copy of Starlight. Phosphor is technically inferior so there is no point updating it.

PweSol avatar Jun 10 '23 06:06 PweSol

Who knows, there could still be improvements to be made somewhere

64BitUniverse avatar Jun 10 '23 16:06 64BitUniverse

I would love to see Phosphor be updated to 1.20[.1],

NotLicense14 avatar Jun 19 '23 17:06 NotLicense14

@HowardZHY Phosphor is not needed as Minecraft 1.20 hugely optimised the lighting engine. It’s still not as fast as Starlight, but it is much faster and much closer to Starlight speeds because it has more checks for stability purposes (which Minecraft being bug free is important!)

mrjasonn avatar Jun 24 '23 13:06 mrjasonn

@HowardZHY Phosphor is not needed as Minecraft 1.20 hugely optimised the lighting engine. It’s still not as fast as Starlight, but it is much faster and much closer to Starlight speeds because it has more checks for stability purposes (which Minecraft being bug free is important!)

I just wonder if there could still be improvements to be made somewhere

HowardZHY avatar Jun 24 '23 13:06 HowardZHY

Maybe you can find those possible improvements and submit a PR, then. There’s no need for phosphor to update past 1.19 right now, as the lighting engine it improved has been entirely replaced in 1.20 vanilla with one that’s significantly faster than 1.19 with phosphor, and more stable than 1.19 with starlight. The old optimizations no longer apply, and new ones haven’t yet been found.

astridellensdottir avatar Jun 24 '23 13:06 astridellensdottir

https://gist.github.com/Spottedleaf/6cc1acdd03a9b7ac34699bf5e8f1b85c

See here

42willow avatar Jun 24 '23 21:06 42willow

We don't know if there will be a port of MC 1.20. Right now, most of Phosphor's patches are rendered broken and/or obsolete. It remains to be seen if there are any significant optimizations which exist for the newer lighting engine that are useful outside of very large servers.

I wouldn't expect a "port" any time soon. If there is an update, it would likely look very different compared to earlier releases.

jellysquid3 avatar Jun 25 '23 00:06 jellysquid3

Will it update to 1.20?

No, because 1.20 has improved it's lightning engine performance dramatically, so phosphor it not necessary anymore I'm those versions, Neither does Starlight.

13Ralef avatar Mar 08 '24 15:03 13Ralef