lithium-fabric icon indicating copy to clipboard operation
lithium-fabric copied to clipboard

fix: Make GH Actions consistent with Sodium's

Open Crackers0106 opened this issue 3 years ago • 2 comments

Noticed while updating to the latest dev builds of Lithium and Sodium that the artifacts produced were different, such as Sodium's naming for the build artifacts file being sodium-artifacts-(branch name) and only including the Minecraft compatible jar file.

Ideally, it feels like these should be pretty much the same between the three mods, and could make it easier to tell which file has which artifacts inside if you have a dozen files named build-artifacts.zip downloaded with no way to tell what they're for without checking inside them like I do.

This is my first PR, so I hope I'm doing this right

Crackers0106 avatar Dec 07 '21 03:12 Crackers0106

    # Filter built files to disregard -sources and -dev, and leave only the minecraft-compatible jars.
    path: build/libs/*[0-9].jar

Doesn't seem to work

2No2Name avatar Dec 07 '21 23:12 2No2Name

This clearly happens because lithium uses a different jar naming system. Changing to sodiums naming system might be a good idea

2No2Name avatar Dec 08 '21 09:12 2No2Name