hydrogen-fabric icon indicating copy to clipboard operation
hydrogen-fabric copied to clipboard

Hydrogen 0.3.1 increases memory usage in 1.17.1

Open FwuffyPetsOwO opened this issue 2 years ago • 2 comments

Using Hydrogen 0.3.1 with 1.17.1 increases memory usage compared to without Hydrogen. Hydrogen 0.3.0 does not have this issue.

Vanilla environment test results: https://discord.com/channels/602796788608401408/602805971391217683/871254018310152313

Modpack "Valhesia Fabric 1.17" results: https://discord.com/channels/602796788608401408/602805971391217683/871260901808959538

Modpack with Hydrogen 0.3.0: https://discord.com/channels/602796788608401408/602805971391217683/871265091536973864

It seems 0.3.1 is causing some regression compared to 0.3.0

FwuffyPetsOwO avatar Aug 01 '21 05:08 FwuffyPetsOwO

Using Hydrogen 0.3.1 with 1.17.1 increases memory usage compared to without Hydrogen. Hydrogen 0.3.0 does not have this issue.

Vanilla environment test results: https://discord.com/channels/602796788608401408/602805971391217683/871254018310152313

Modpack "Valhesia Fabric 1.17" results: https://discord.com/channels/602796788608401408/602805971391217683/871260901808959538

Modpack with Hydrogen 0.3.0: https://discord.com/channels/602796788608401408/602805971391217683/871265091536973864

It seems 0.3.1 is causing some regression compared to 0.3.0

Can you post screenshots on imgur they are not available on the discord link so it will be easier for the creators of the mod to fix the problem (i'm not a creator) just wondering

ghost avatar Sep 09 '21 13:09 ghost

Note that the only code change from 0.3.0 to 0.3.1 was https://github.com/CaffeineMC/hydrogen-fabric/commit/e64d9701f27bcd786bf8e60515cd8e8f73379583, which simplifies Hydrogen's code to assume Java 16 is used.

Echoing the comment above to please send your results to an image hosting site or uploading them directly to a GitHub comment

amnotbananaama avatar Sep 09 '21 13:09 amnotbananaama