ChroMapper icon indicating copy to clipboard operation
ChroMapper copied to clipboard

Add the new Environments!

Open theoneguy-real opened this issue 1 year ago • 6 comments

There's been a few new environments after the last one on the list in the app, and I think they should be added.

New environments would mean more places to make maps with even cooler lightshows!

The ones not added are: Daft Punk Imagine Dragons V2 Electronic Mixtape Fall Out Boy Hip-Hop Mixtape Lady Gaga Linkin Park V2 Lizzo "NiceEnvironment" OST 4/5/6 Environments Panic! At The Disco V2 Rock Mixtape Queen The Rolling Stones The Weeknd "WeaveEnvironment"

theoneguy-real avatar Mar 18 '24 14:03 theoneguy-real

Feel free to open a PR when you've done it :)

Top-Cat avatar Mar 18 '24 14:03 Top-Cat

Feel free to open a PR when you've done it :)

wait what does that mean i know what a pull request is, but i can't add the environments myself i'm not that talented

theoneguy-real avatar Mar 18 '24 14:03 theoneguy-real

Feel free to open a PR when you've done it :)

I couldn't find any documentation in this project for how environments are implemented

valentinegb avatar Jul 30 '24 23:07 valentinegb

Documentation doesn't exist. It's pretty much all from figuring out the code in the Platforms folder.

Though keep in mind we're looking at updating CM to support v4 format and it's likely to cause merge conflicts with any significant work with v3 lighting if you're planning on it.

XAce1337manX avatar Jul 31 '24 00:07 XAce1337manX

Adding platforms is a lot of work. Adding proper v3 support will almost certainly require a complete rewrite of everything platforms related. Adding a v3 lighting workflow that comes close to matching the Official editor will be extremely difficult and time consuming, nigh on impossible.

There are better priorities we'd like to focus on. People interested in newer environments can use the Official editor. It's really the best in class for everything with the latest lighting system.

Caeden117 avatar Jul 31 '24 00:07 Caeden117

People interested in newer environments can use the Official editor.

I can't use the official editor... it's not on Mac. But alright, I can understand that adding the new environments are not a high priority right now with what you guys just said

valentinegb avatar Jul 31 '24 00:07 valentinegb