ChroMapper icon indicating copy to clipboard operation
ChroMapper copied to clipboard

ADB is not closed when Chromapper is closed

Open Silver-Volt4 opened this issue 1 year ago • 2 comments

ChroMapper version v0.8.489

Describe the Issue ADB is not closed when Chromapper is closed. This leaves an adb.exe process in the task manager. Most notably, it will prevent any actions on Chromapper's install folder (moving, renaming)

Provide Screenshots or Videos obrazek

Steps to Reproduce Set up CM to use ADB (I did this on first run), then open and close CM

Expected Behavior No dangling process

Silver-Volt4 avatar Sep 12 '22 15:09 Silver-Volt4

I wouldn't exactly say this is a bug, since it's how adb is supposed to work (it's a daemon). I guess the adb process could be a subprocess of CM which would close it when CM closes though. (at least, I assume)

How does this cause a problem for CM though? It doesn't rename the executable to my knowledge and it does properly kill the process if one were to uninstall it within CM last I checked.

Fernthedev avatar Sep 17 '22 05:09 Fernthedev

How does this cause a problem for CM though?

Windows locks the quest-utils folder. Mine is in the same one as the main executable. When I tried moving CM's install folder, I was denied because it was "open in another program", that program being the ADB process.

Silver-Volt4 avatar Sep 18 '22 21:09 Silver-Volt4