cadquery icon indicating copy to clipboard operation
cadquery copied to clipboard

Screenshots broke

Open dAnjou opened this issue 1 month ago • 1 comments

Hi, and sorry for the crappy title 🙈

I'm the one from #1854, and I just got around to updating my CadQuery dependency to include your fix for that issue.

I figured I might as well point to master to get the latest stuff, but unfortunately it broke my screenshots again, but in a different way: https://gitlab.com/dAnjou/bed/-/jobs/12385565218/artifacts/file/public/bed/bed_front.png.

When I point to the exact commit that is your fix (782112157c6c613805027adc17af0e41f6ed5967), then things look fine again: https://gitlab.com/dAnjou/bed/-/jobs/12385674113/artifacts/file/public/bed/bed_front.png

So, something in these commits has done that: https://github.com/CadQuery/cadquery/compare/782112157c6c613805027adc17af0e41f6ed5967...7221407ceeba1b23276ffa123f28c4b34b36029b

Let me know if there's something I should change in my calls to show 🙂

Cheers!

dAnjou avatar Dec 10 '25 11:12 dAnjou

Yeah, a clipping plane problem.

You maybe can also try https://github.com/jmwright/cadquery-png-plugin. This plugin makes better screenshots / images then the show version and also works better. There is a version on pypi.org so no need to install from source.

However, the plugin is only available for the assemblies.

Jopie01 avatar Dec 10 '25 18:12 Jopie01

Thanks @Jopie01! I took a brief look, didn't try it yet though. Can you elaborate (maybe update the README), how the screenshots are different or better even? The code seems to do a very similar thing like CadQuery's screenshots.

dAnjou avatar Dec 11 '25 09:12 dAnjou

They do both kind of the same, but the plugin gives you more control and is specifically created to export an rendered image. The show function is primarily created to show the model interactively and can export the screen to an image. Rendering gives IMO a much nicer look. You can see some examples in https://github.com/jmwright/cadquery-png-plugin/issues/3 of the differences.

Jopie01 avatar Dec 11 '25 10:12 Jopie01

@dAnjou this is a regression from #1855. I can reproduce the issue also without taking screenshots. #1951 should fix it.

@Jopie01 if you miss a feature from show or find a bug, please open a separate issue or a PR. Blanket statements in specific issues are not very helpful.

adam-urbanczyk avatar Dec 12 '25 07:12 adam-urbanczyk