cadquery icon indicating copy to clipboard operation
cadquery copied to clipboard

`cskHole` generates incorrect results for shallow holes

Open TheLostLambda opened this issue 1 year ago • 1 comments

https://github.com/CadQuery/cadquery/blob/3cd327a2dbaf3bae6791463a3dcb0ad7a714b607/cadquery/cq.py#L2930-L2988

If the cone generated by the angle and diameter is taller than the depth of the hole, it still cuts through and forms a conical cutout where I think it should be truncated.

I'll add more details soon, and am also happy to submit a PR myself unless someone beats me to it!

TheLostLambda avatar Aug 29 '24 13:08 TheLostLambda