cadquery icon indicating copy to clipboard operation
cadquery copied to clipboard

Fix Assembly Location handling when applied at top level

Open lorenzncode opened this issue 1 year ago • 1 comments

Fixes #1594

lorenzncode avatar May 28 '24 03:05 lorenzncode

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.92%. Comparing base (9ee703d) to head (a690fa8). Report is 7 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1595   +/-   ##
=======================================
  Coverage   94.91%   94.92%           
=======================================
  Files          28       28           
  Lines        6259     6263    +4     
  Branches     1271     1273    +2     
=======================================
+ Hits         5941     5945    +4     
  Misses        192      192           
  Partials      126      126           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 28 '24 03:05 codecov[bot]

@lorenzncode we need to get this merged, but do you have any thoughts/updates on the comments above?

adam-urbanczyk avatar Jul 03 '24 16:07 adam-urbanczyk

@lorenzncode we need to get this merged, but do you have any thoughts/updates on the comments above?

Yes, I'll comment later today. Please hold any merge for now.

lorenzncode avatar Jul 03 '24 16:07 lorenzncode

Thanks!

adam-urbanczyk avatar Jul 03 '24 17:07 adam-urbanczyk

Superseded by #1623

adam-urbanczyk avatar Jul 05 '24 15:07 adam-urbanczyk