cadquery icon indicating copy to clipboard operation
cadquery copied to clipboard

Closes #786 Asymmetric Chamfer Error

Open kolod opened this issue 9 months ago • 1 comments

Closes #786 Asymmetric Chamfer Error

cadquery uses random edge face when call into chamfer_builder.Add()

Fix uses face on which edge selected in chamfer_builder.Add() call

Example:

Workplane().box(10, 10, 10).faces("<X").chamfer(1, 2)

image

If both faces of the edge are selected chamfer now uses length2 for length to prevent unexpected behavior.

Example:

Workplane().box(10, 10, 10).faces("<Y or <X").edges("|Z").chamfer(1, 2)

image

kolod avatar May 01 '24 19:05 kolod

Thanks for the PR, but looks like you still fail on mypy (annotations) and call show from the test which causes an error on azure. We'll probably need to discuss the proposed semantics too.

adam-urbanczyk avatar May 03 '24 20:05 adam-urbanczyk