cadquery
cadquery copied to clipboard
stop `eachpoint(..., useLocalCoordinates=False)` from manipulating the object's location
fixes https://github.com/CadQuery/cadquery/issues/1099
Even better would be a change that turns eachpoint()
into a thin wrapper around each()
with only the logic for converting the objects to points.
@greyltc The eachpoint test seems to be failing on this PR.
Sorry, maybe I'm looking in the wrong place, but I can't see the details of the failure. All I can see is
Check failure on line 1059 in Build log
@azure-pipelinesazure-pipelines
/ CadQuery.cadquery (Linux_3_10)
Build log #L1059
Bash exited with code '1'.
I clicked on "View more details on Azure Pipelines" there but that takes me to a page that says "build not found".
This PR makes a fundamental change to the way eachpoint
works with useLocalCoordinates=False
so I assume the test pass criteria needs to be rewritten to match that, but it would be nice to see the verbose check failure output to make sure.
Codecov Report
Merging #1100 (87890b8) into master (a5fadeb) will decrease coverage by
2.27%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## master #1100 +/- ##
==========================================
- Coverage 96.34% 94.07% -2.28%
==========================================
Files 40 26 -14
Lines 9533 5421 -4112
Branches 1259 919 -340
==========================================
- Hits 9185 5100 -4085
+ Misses 205 190 -15
+ Partials 143 131 -12
Impacted Files | Coverage Δ | |
---|---|---|
cadquery/cq.py | 92.20% <100.00%> (-0.24%) |
:arrow_down: |
cadquery/occ_impl/exporters/assembly.py | 100.00% <0.00%> (ø) |
|
tests/test_cadquery.py | ||
tests/test_sketch.py | ||
tests/test_utils.py | ||
tests/test_cad_objects.py | ||
tests/test_assembly.py | ||
tests/test_hull.py | ||
tests/test_cqgi.py | ||
... and 19 more |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more