CQ-editor icon indicating copy to clipboard operation
CQ-editor copied to clipboard

[WIP] Adding Binary Builds to Azure Pipelines

Open jmwright opened this issue 4 years ago • 8 comments

@adam-urbanczyk I realized that I couldn't properly test the triggers unless this was on a fork. My fork still includes GitHub Actions builds, but we can decide whether or not to take those files out before merge.

I'm just getting started on this, but I wanted to get this rolling and allow feedback and changes.

It's my first time using a draft PR, so I'll be learning that workflow too.

jmwright avatar Feb 08 '21 13:02 jmwright

Addresses #221

jmwright avatar Feb 08 '21 13:02 jmwright

@adam-urbanczyk Would you rather I start with a clean fork without all the GitHub Actions commits? I just noticed there are a ton of them.

jmwright avatar Feb 08 '21 13:02 jmwright

Codecov Report

Merging #223 (d82c04a) into master (bc05b6b) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #223   +/-   ##
=======================================
  Coverage   88.55%   88.55%           
=======================================
  Files          19       19           
  Lines        1546     1546           
  Branches      187      187           
=======================================
  Hits         1369     1369           
  Misses        143      143           
  Partials       34       34           

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Feb 08 '21 14:02 codecov[bot]

@jmwright does not matter, I will squash in the end.

adam-urbanczyk avatar Feb 09 '21 06:02 adam-urbanczyk

@adam-urbanczyk I'm looking for some guidance on Azure pipelines. I have a fork of conda-packages that has the beginnings of a template. I also have my fork of CQ-editor where I'm trying to integrate that template into a job. I would like to test those without merging them into the master branches of the main repos. However, I think the only way to do that may be to add a github service connection for my conda-packages fork (jmwtemplates). I don't seem to have access to the properties section of the main CQ-editor repo to add that though. So I guess there are two questions.

  1. Am I going about this wrong? This is new territory for me.
  2. If not, how do I get access to add a GitHub Service Connection?

jmwright avatar Feb 10 '21 01:02 jmwright

I forgot about this... Does this kind of approach work (ofc you need to adjust the urls):

# Repo: Contoso/WindowsProduct
# File: azure-pipelines.yml
resources:
  repositories:
    - repository: templates
      type: github
      name: Contoso/BuildTemplates
      ref: refs/tags/v1.0 # optional ref to pin to

jobs:
- template: common.yml@templates  # Template reference
  parameters:
    vmImage: 'vs2017-win2016'

adam-urbanczyk avatar Apr 13 '21 16:04 adam-urbanczyk

Is this still WIP?

adam-urbanczyk avatar Aug 17 '21 16:08 adam-urbanczyk

Between the Azure login issues and trouble getting template URLs to work I ran out of time and motivation to work on this. Feel free to close and I'll reopen if I circle back to it.

jmwright avatar Aug 17 '21 16:08 jmwright

@jmwright can I close this PR?

adam-urbanczyk avatar Jul 24 '23 20:07 adam-urbanczyk

+1 for closing

jmwright avatar Jul 24 '23 20:07 jmwright

Thanks for the work!

For the record, currently supported way is via constructor. See: https://github.com/CadQuery/CQ-editor/releases/tag/nightly

adam-urbanczyk avatar Jul 24 '23 20:07 adam-urbanczyk