plugin_thold icon indicating copy to clipboard operation
plugin_thold copied to clipboard

Fix #621 notifications

Open unka65 opened this issue 1 year ago • 4 comments

This fixes the unexpected and missing notifications. This does not address determining if a threshold has been reached.

Changed maintenance mode so no unexpected notify (to normal but no warning/alert) after off maintenance.

Eliminated missing and unexpected high/low notifications by not clearing counters at warning and alert level until notified. If at warning level, included alert counts not notified.

Moved Alert to Warning section so that can occur. This made the changes seem more significant than actual.

Fixed error (thold_id not valid) for baseline type in get_email_subject: changed thold_id to thold_hi

unka65 avatar Feb 15 '24 14:02 unka65

I'll be reviewing this over the weekend.

TheWitness avatar Feb 17 '24 18:02 TheWitness

Getting back to this now. I'm going to merge commit these one at a time as I rationalize the changes. Hope that's okay with you.

TheWitness avatar Apr 05 '24 19:04 TheWitness

@unka65 please check my last comment in case you missed the notification.

TheWitness avatar Apr 05 '24 19:04 TheWitness

@unka65, update to the latest develop and rework your patches after you read through my latest comments. The re-update your poll request.

I will take a second look then.

TheWitness avatar Apr 05 '24 19:04 TheWitness