plugin_thold icon indicating copy to clipboard operation
plugin_thold copied to clipboard

Missing input validation - notification lists -> any list -> Thresholds

Open xmacan opened this issue 3 years ago • 2 comments

I don't know if plugins also require this check. The notify_lists.php is missing in many places: 2022-04-07 17:31:00 - CMDPHP Input Validation Not Performed for 'id' Backtrace: (/plugins/thold/notify_lists.php[58]:form_actions(), /plugins/thold/notify_lists.php[426]:get_request_var(), /lib/html_utility.php[394]:html_log_input_error(), /lib/html_validate.php[44]:cacti_debug_backtrace()) 2022-04-07 17:31:00 - CMDPHP Input Validation Not Performed for 'notification_alert_action' Backtrace: (/plugins/thold/notify_lists.php[58]:form_actions(), /plugins/thold/notify_lists.php[421]:get_request_var(), /lib/html_utility.php[394]:html_log_input_error(), /lib/html_validate.php[44]:cacti_debug_backtrace()) 2022-04-07 17:31:00 - CMDPHP Input Validation Not Performed for 'notification_warning_action' Backtrace: (/plugins/thold/notify_lists.php[58]:form_actions(), /plugins/thold/notify_lists.php[401]:get_request_var(), /lib/html_utility.php[394]:html_log_input_error(), /lib/html_validate.php[44]:cacti_debug_backtrace())

I can fix it, if you want.

Cacti 1.2.20 Thold 1.6

xmacan avatar Apr 25 '22 19:04 xmacan

I also get some kind of errrors in: 2022/08/31 12:57:00 - CMDPHP Input Validation Not Performed for 'host_id' Backtrace: (/plugins/thold/thold.php[87]:save_thold(), /plugins/thold/thold_functions.php[4468]:get_request_var(), /lib/html_utility.php[379]:html_log_input_error(), /lib/html_validate.php[44]:cacti_debug_backtrace())

@xmacan PR's are always welcome :)

interduo avatar Aug 31 '22 11:08 interduo

Fixed.

TheWitness avatar Aug 31 '22 22:08 TheWitness

Thanks - its done. Why You don't close the issue?

interduo avatar Sep 22 '22 11:09 interduo